refactor: delete the dashboard, which nothing could reach - #40
Merged
Conversation
`/` is four lines that unconditionally redirect to `/diff`, with no condition and no other caller, so the dashboard component was rendered by nothing. Everything behind it was dead in the same way: the commit list, the overview file list, `useCommits`, `useOverview`, their query modules, their fetch wrappers, their types, and the `/api/overview` and `/api/commits` routes serving them. 354 lines. Nothing else referenced any of it. `packages/git` keeps `getRecentCommits`, `getStagedFiles` and `getUnstagedFiles`. That is a library with its own exports rather than unreachable UI, and this fork tracks what it can offer upstream — the server just no longer imports them. v0.9.18. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
Self-review. The previous commit kept `packages/git`'s exports because the fork tracked what it could offer upstream. That stopped being true today, so the boundary is redrawn on the reason that survives. `getStagedFiles` and `getUnstagedFiles` had no caller and no test, and `execLines` went with them — internal, unexported, nothing else used it. `status.ts` keeps `isDirty`, which is used. `getRecentCommits` stays, for a reason that holds on its own: `shell-injection.test.ts` is a regression test against command substitution in a search argument, and deleting the function deletes the test. UPSTREAM.md now says upstream is retired and why, so the next reader does not keep something for a reason that expired. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You could not find commit browsing because it is not reachable.
routes/_index.tsxis four lines that unconditionallyredirect("/diff")— no condition, no other caller — soDashboardwas rendered by nothing.Everything behind it was dead the same way, and nothing else referenced any of it:
dashboard.tsxcommit-list.tsxoverview-file-list.tsxuse-commits.ts,use-overview.tsqueries/commits.ts,queries/overview.tsfetchCommits,fetchOverview, and theCommit/Overview/OverviewFile/CommitsPagetypes/api/overview,/api/commitsroutes354 lines.
Deliberately kept:
packages/gitstill exportsgetRecentCommits,getStagedFilesandgetUnstagedFiles. That is a library with its own surface rather than unreachable UI, and this fork tracks what it can offer upstream — the server simply stops importing them.Also confirmed while looking:
/treehas no Ask/Act wiring at all — noonAskThread, noaskIsHeard, nothing. Your reading of it was right. Not touched here.parser 43, git 44, github 21, ui 426, cli 224. Typecheck 0. v0.9.18.
🤖 Generated with Claude Code
https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs